Bug in v4.1.12 -> EditorSetting::set() fails

#1

I use EditorSetting::set() to configure some options automatically when setting up a new project. I just updated my repo from 4.1.9 to 4.1.12 and it fails with this error:

Indirect modification of overloaded property Backend\Models\EditorSetting::$value has no effect

I found that this is caused by this code in EditorSetting:

$this->value[$field][$key]['class_name'] = preg_replace(
    '/[^a-zA-Z0-9_-]/',
    '',
    $row['class_name']
);

I was trying to create a PR in the October repo to fix it, but I can’t see the last code in github, the published version there is 4.1.9. Is the repo not updated with every published version? The correct code would be this:

$value = $this->value;

$value[$field][$key]['class_name'] = preg_replace(
    '/[^a-zA-Z0-9_-]/',
    '',
    $row['class_name']
);

$this->value = $value;

Can you please fix it, or update the repo so I can submit the PR? It’s a little urgent for me because I need to set up a new project.

Thanks!

#2

Hey @Maria_UtopigStudio

Thanks for the heads up. Please try it in v4.1.13

1 Like